-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[WIP] Migrate browserslist-config
package to TypeScript
#70521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Migrate browserslist-config
package to TypeScript
#70521
Conversation
I am debugging the failing tests and working on fixing them. |
576bce8
to
80c05d4
Compare
So, the reason for still keeping the The Here's what happens when the main entry points to Cannot find module '/Users/hp/gutenberg/node_modules/@wordpress/browserslist-config/build/index.js' This error occurs because:
This same issue affects other config packages too - see #70533 So the question is: What's the proper solution? The current workaround prevents build failures but isn't a complete migration. This also raises another question: Do config packages even need to be migrated? They don't have complex logic that would benefit from type safety. They're just low-level dependencies that other packages import during build. |
I think it's fine to leave this package as js only. |
I agree with this; this package is just a configuration file and does not contain any logic. |
What?
Part of: #67691
Migrating the
packages/browserslist-config
package to TypeScript.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast