-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Post Author: Optimize and improve user control queries #70510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +205 B (+0.01%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
Flaky tests detected in 2ad0780. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15848805624
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mamaduka
Good change. Much better than the drop down with the 25 min limit. Searching works well, and the initial HTTP /users
on page load is avoided until you interact with the block.
Logged in as editor in trunk
Before | After |
---|---|
I logged in as an author and the combobox wasn't available 👍🏻
Thanks for review, @ramonjd! |
What?
Part of #45668.
PR makes the following improvements to the Post Author block:
Why?
The general plan is to consolidate similar author selection controls across the blocks. I'm avoiding early abstraction of
AuthorCombobox
as suggested in the issue, and here's why:@wordpress/block-editor
can't depend on thecore-data
package.@wordpress/editor
is a high-level package and can only be used byedit-post/edit-site
packages.block-library
package, which I'll handle as the last step of Unify user selection controls across the blocks #45668.How?
The refactoring closely mimics the
PostAuthor
component logic from theeditor
package.Testing Instructions
editor
user role.author
user role.Testing Instructions for Keyboard
Same.
Screenshots or screencast