Update circle icons to have a unified footprint #70581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -143 B (-0.01%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 1, 2025
|
The failing unit test is unrelated - #70567 (comment). |
This was referenced Jul 23, 2025
Merged
Closed
This was referenced Jul 28, 2025
Merged
|
@jasmussen @Mamaduka This change broke some icons. currencyDollar for example goes from a $ in a circle, to just a dotted circle |
|
@danieliser Thanks for the report. I also confirmed the problem. The gutenberg/packages/icons/src/library/currency-dollar.tsx Lines 6 to 10 in 30d3b38 gutenberg/packages/icons/src/library/swatch.tsx Lines 6 to 10 in 30d3b38 |
This was referenced Jul 31, 2025
fix(address-widget): use the correct
inputmode for the postal code field
myparcelnl/woocommerce#1375
Merged
Open
Merged
|
My apologies for the tardy fix and thank you for the report. I have a fix in #71042. |
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #70299. There are a number of circular icons that are not the correct size as defined by the icon blueprint template, and are arbitrarily larger:
This PR addresses the remaining ones, ensuring all circular icons are uniform in size.
Testing Instructions
Run storybook: npm run storybook:dev, then go to Icons > Library, then check the following icons: