Skip to content

ServerSideRender: Remove the 'POST' method shim example #70577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jul 1, 2025

What

PR updates documentation for httpMethod argument and removes POST endpoint shim example. I've also adjusted the argument description.

Why?

WordPress 5.5 was released almost five years ago. This example is redundant now.

Testing Instructions

None. It's a documentation update.

@Mamaduka Mamaduka self-assigned this Jul 1, 2025
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jul 1, 2025
@Mamaduka Mamaduka requested review from talldan and fabiankaegy July 1, 2025 05:59
Copy link

github-actions bot commented Jul 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the [Package] Server Side Render /packages/server-side-render label Jul 1, 2025
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good find :)

@fabiankaegy fabiankaegy merged commit 359dd71 into trunk Jul 1, 2025
87 of 89 checks passed
@fabiankaegy fabiankaegy deleted the remove/ssr-http-method-post-shim-example branch July 1, 2025 12:30
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jul 1, 2025
@Mamaduka
Copy link
Member Author

Mamaduka commented Jul 1, 2025

Thanks, @fabiankaegy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Server Side Render /packages/server-side-render [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants