DataViews: More fields, controls and operators #70567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10.2 kB (+0.55%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a2762cd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15971012635
|
Mamaduka
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Thanks, @youknowriad and @oandregal!
I couldn't spot any regression while smoke testing the DataViews in the Site Editor.
|
I forgot about the props, it's been some time 😬 |
|
@youknowriad, I noticed that one related unit test became flaky after this got merged - https://github.com/WordPress/gutenberg/actions/runs/15999102275/job/45129358727?pr=70576. Screenshot |
|
I'm testing whether the unit tests are stable by using a fake timer: #70582 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63646
Related #55083
Related #59745
What?
With @oandregal and others, we've been iterating on the DataViews and DataForm components to make them more powerful and enable new use-case:
We added stories to cover all of these. This PR brings this change back for everyone to use. I updated the DataViews fields that are being used in the site editor to ensure things continue to work as expected.
Testing Instructions
smoke test the dataviews usage in the site editor.