Skip to content

Cherry-picked bug fixes for 6.8.2 #70557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 8, 2025
Merged

Cherry-picked bug fixes for 6.8.2 #70557

merged 15 commits into from
Jul 8, 2025
+355 −124

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jun 30, 2025 •
edited
Loading

What?

Core ticket: https://core.trac.wordpress.org/ticket/63582

For the WP 6.8.2 release, I cherry-picked the PR labeled Backport to WP Minor Release.

The following PRs are included:

Note

  • The PRs marked with ⚠️ do not have the Backport to WP Minor Release label, but this was necessary to avoid conflicts when cherry-picking.
  • No core backports PRs are needed for PHP files as no PHP files have changed.
  • For reasons why some CIs fail, see Fix Floating UI packages dependencies #70553.

Mamaduka and others added 15 commits June 30, 2025 11:21
@Mamaduka @fabiankaegy @t-hamano
Navigation Link: Don't check validity when block editing is disabled (#…
8410f63 
…69627)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
@Mamaduka @youknowriad @t-hamano
Navigation Link: Optimize 'getBlockParentsByBlockName' selector call (#…
4d35d12 
…69631)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@Mamaduka @fabiankaegy
@t-hamano @talldan
Navigation Link: Improve performance by only requesting entities when…
54572c0 
… selected (#69633)

* Navigation Link: Improve performance by only requesting entities when selected
* Update selector logic for enabling link validation

Unlinked contributors: dretzlaff.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: jordesign <jordesign@git.wordpress.org>
@Mamaduka @fabiankaegy
@carolinan @t-hamano
Query Loop: Don't overwrite the 'query.inherit' attribute value (#69698)
e8a0af6 
* Query Loop: Don't overwrite the 'query.inherit' attribute value
* A misc adjustments
* Display warning next to 'Query Type' control

Unlinked contributors: genemma, cheestudio.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: luminuu <luminuu@git.wordpress.org>
Co-authored-by: jeflopodev <jeflopodev@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org>
@Sukhendu2002 @Mamaduka @t-hamano
Block Editor: Remove truncation from media tab preview tooltips (#69741)
5e80e98 
Unlinked contributors: claimableperch.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
@Mamaduka @t-hamano
Image: Avoid stale URL when reselecting the same image from the libra…
0303378 
…ry (#69985)

Unlinked contributors: T4ngml.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@Mamaduka @t-hamano
Post Template: Don't rely on the default 'ignore_sticky' REST API val…
08682c6 
…ue (#70020)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@Mayank-Tripathi32 @t-hamano @Mamaduka
MediaPlaceholder: Fix Regression with media URL input type to allow a…
f52edfc 
… local URL path (#70043)

Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: skierpage <skierpage@git.wordpress.org>
@t-hamano @Mamaduka
DOM: Add summary element to focusable elements (#70051)
25ebdc1 
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
@t-hamano @Mamaduka
Button: Limit scope of width style for link (#70054)
48803db 
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: luminuu <luminuu@git.wordpress.org>
@im3dabasia @carolinan
@Mamaduka @t-hamano
Details: Enable all non-interactive formats (#68741)
cacd2c8 
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
@yogeshbhutkar @Mamaduka
@t-hamano @joedolson
Details Block: Fix keyboard accessibility issues and allow list view …
595b997 
…selection to show up inner blocks (#70056)

* fix: use key down to open/close the details block

* chore: fix import order

* fix: do not conditionally render details children

* feat: expose `withIgnoreIMEEvents` to private api

* feat: wrap handler within `withIgnoreIMEEvents`

* chore(test): add e2e test for details block

* fix: prevent space in rich-text from toggling details

* chore: add CHANGELOG

* fix: wrap key up handler with `withIgnoreIMEEvents`

* chore(e2e): updated tests

* Adds using inner block content wherever required
* Adds an e2e test to verify list view auto expand and focus

* chore: move `CHANGELOG` to unreleased

* chore: revert usage of `withIgnoreIMEEvents`

* fix: apply `withIgnoreIMEEvents` to key down

Manual testing with IMEs showed that the HOF can safely be applied just to the key down events

* feat: add visually hidden instructions for expanding/collapsing details

* fix: add `aria-describedby` and add it to RichText

* fix: update aria-label for RichText

* fix: remove the usage of `aria-describedby`

* chore: move `CHANGELOG` to unreleased

Unlinked contributors: armandovias.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: alexstine <alexstine@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: megane9988 <megane9988@git.wordpress.org>
@Mamaduka @tyxla
@t-hamano @annezazu
URL: Handle HTML entities and ampersand in 'cleanForSlug' (#70078)
4353d71 
Unlinked contributors: APCgit.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Soean <soean@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: 2ndkauboy <kau-boy@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: marcarmengou <marc4@git.wordpress.org>
Co-authored-by: tharsheblows <tharsheblows@git.wordpress.org>
@peterwilsoncc @fabiankaegy
@swissspidy @t-hamano
Remove screencast.com embed block variation. (#70480)
a7e5cb5 
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
@t-hamano
Fix Floating UI packages dependencies (#70553)
a96bc3d 
* Fix Floating UI packages dependencies

* Pin @floating-ui/react-dom version
@t-hamano t-hamano self-assigned this Jun 30, 2025
@t-hamano t-hamano marked this pull request as ready for review July 7, 2025 14:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Mamaduka
Mamaduka approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested the editors and a couple of fixes that are listed in the PR. Everything seems to be in order ✅

I can also confirm that merging this branch into wp/6.8 resolves npm ci failures, which is currently a reason for some failing CI checks.

@Mamaduka Mamaduka merged commit 773e409 into wp/6.8 Jul 8, 2025
61 of 68 checks passed
@Mamaduka Mamaduka deleted the bug-fixes-for-6.8.2 branch July 8, 2025 03:51
This was referenced Jul 8, 2025
Merged
Merged
Merged
Merged
This was referenced Jul 8, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Mamaduka Mamaduka mentioned this pull request Jul 8, 2025
Closed
@bobbrodie bobbrodie mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@artemiomorales artemiomorales Awaiting requested review from artemiomorales artemiomorales is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@t-hamano t-hamano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@t-hamano @Mamaduka @Sukhendu2002 @Mayank-Tripathi32 @im3dabasia @yogeshbhutkar @peterwilsoncc