Skip to content

e2e: Re-enable skipped E2E tests related to the settings REST API #70551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2025
Merged

e2e: Re-enable skipped E2E tests related to the settings REST API #70551

merged 2 commits into from
Jun 28, 2025

Conversation

Adi-ty
Copy link
Contributor

@Adi-ty Adi-ty commented Jun 28, 2025 •
edited
Loading

What?

Closes #70461

Re-enables three E2E tests that were temporarily disabled due to WordPress Core REST API issues with the settings endpoint.

Why?

Three E2E tests were temporarily disabled in #70460 due to a regression in WordPress Core's REST API settings endpoint validation. WordPress Core has now resolved both the original validation issue and the regression (WordPress Core Trac #41604), making it safe to re-enable these E2E tests.

How?

Removed test.skip() calls from three E2E tests that were temporarily disabled

Testing Instructions

  1. Run the site title E2E test: npm run test:e2e -- test/e2e/specs/editor/blocks/site-title.spec.js
  2. Run the multi-entity saving E2E test: npm run test:e2e -- test/e2e/specs/editor/various/multi-entity-saving.spec.js

Adi-ty and others added 2 commits June 18, 2025 10:48
@Adi-ty
Fix: Re-enable disabled E2E tests for core settings REST API
8170621 
Update parameter handling in core settings E2E tests to work with
WordPress Core REST API validation changes from Trac ticket WordPress#41604.
Fixes WordPress#70461
@Adi-ty
Merge branch 'WordPress:trunk' into fix/re-enable-skipped-e2e-tests
5a79be9
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 28, 2025
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Adi-ty! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Adi-ty Adi-ty changed the title e2e: Re-enable skipped E2E tests e2e: Re-enable skipped E2E tests related to the settings REST API Jun 28, 2025
@t-hamano t-hamano requested review from t-hamano and Copilot June 28, 2025 13:00
Copilot
Copilot AI reviewed Jun 28, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables three E2E tests for the settings REST API after the underlying issue in WordPress Core has been resolved.

  • Re-enabled the "Save flow should work as expected" test in the Multi-entity saving spec.
  • Re-enabled the "Site blocks should save individually" test in the Multi-entity saving spec.
  • Re-enabled the "Can edit the site title as admin" test in the Site Title block spec.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/e2e/specs/editor/various/multi-entity-saving.spec.js Removed test.skip() calls to re-enable multi-entity save tests.
test/e2e/specs/editor/blocks/site-title.spec.js Removed test.skip() call to re-enable the site title test.

@t-hamano t-hamano added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jun 28, 2025
t-hamano
t-hamano approved these changes Jun 28, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This PR appears to be in draft status, but I believe all of the changes are correct.

@t-hamano t-hamano marked this pull request as ready for review June 28, 2025 13:01
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Adi-ty <iamadisingh@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano merged commit 82f0fcb into WordPress:trunk Jun 28, 2025
66 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@t-hamano t-hamano t-hamano approved these changes

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 21.2
Development

Successfully merging this pull request may close these issues.

e2e: Reinstate skipped E2E tests related to the settings REST API
2 participants
@Adi-ty @t-hamano