-
Notifications
You must be signed in to change notification settings - Fork 4.5k
IAPI: Fix wp-each
when items are accessed using derived state
#70424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DAreRodz
wants to merge
6
commits into
trunk
Choose a base branch
from
fix/iapi-wp-each-list-replaced
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +176 B (+0.01%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
10 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Interactivity API
API to add frontend interactivity to blocks.
[Packages] Interactivity
/packages/interactivity
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug in the
wp-each
directive that happens when the directives inside the template access the current item using derived state. E.g.,Why?
The bug appeared in WooCommerce while working on an iAPI-powered Minicart block.
Related issue: woocommerce/woocommerce#58673.
This could affect other developers using the Interactivity API.
How?
The problem appears to be related to the reactive context instantiated for each item within the
data-wp-each
directive callback. When the template element re-renders, those reactive contexts are instantiated again, while the internal signals associated with the derived state continue to be subscribed to the old reactive contexts.This bug fix maintains the same reactive contexts for items with the same key when the template element is re-rendered.
Testing Instructions
TBD