-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Remove screencast.com embed block variation. #70480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -49 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this :)
I would like to propose backporting this to the 6.8 branch so that it is included in 6.8.2 |
I confirm we'll want to backport this to 6.8.2. |
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
This PR was cherry-picked into the |
What?
Remove the screencast.com embed block variation.
Closes
Why?
A refactor of systems at screencast.com has broken existing embeds and removed the existing oembed endpoint.
https://api.screencast.com/external/oembed
now returns a410 Gone
response.See the lengthy discussion on the WP-Dev ticket from comment 35 onwards.
WP-Dev Trac ticket: https://core.trac.wordpress.org/ticket/61941
Follow up to r40574 / WordPress/wordpress-develop@9a2188d
How?
Deletes the variation.
Testing Instructions
/screencast
does show block in editorTesting Instructions for Keyboard
Screenshots or screencast