-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Docs: Fix broken links on Developer.WordPress.org #70473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I would like to add @OpuRockey, who first reported this issue, to the props (co-authors of the commit).
* Docs: Use absolute path in link to ensure it works on developer.wordpress.org import. * Docs: Update link to work on developer.wordpress.org * Docs: Use absolute link to ensure it works on developer.wordpress.org Co-authored-by: dd32 <dd32@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: OpuRockey <opurockey@git.wordpress.org>
What?
Closes https://meta.trac.wordpress.org/ticket/8014
Some links in the Block handbook are not being transformed correctly, while this would ideally be resolved on the WordPress.org Importer side, the GitHub markdown transformer doesn't have the context of the current path of the post and so can't correctly transform these relative URLs.
Why?
Because fixing the importer is much-much harder.
How?
Absolute links
Testing Instructions