Fix: ensure submenu toggle in nested nav items doesn’t get flipped #70334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +36 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jun 5, 2025
There was a problem hiding this comment.
Thanks for the PR!
This PR works correctly when the "Open on click" is disabled, but not when the "Open on click" is enabled.
- The text is flipped.
- The arrow is not flipped.
In my opinion, it is better to change the original style rather than adding an override style. In other words, I think we should use .wp-block-navigation__submenu-icon as the CSS selector.
Another question is whether to flip the arrows in nested menus as well. Which do you think is better?
| Flip arrows in nested menus | Don't flip arrows in nested menus |
|---|---|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes
Follow up to #70307
Ensure that the submenu toggle indicator doesn't get flipped for nested submenu items on larger viewports.
Why?
Because they are rotated already to be horizontal instead of vertical.
How?
Adding an override in the media query