Skip to content

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Jun 4, 2025

What?

innerBlockCount is an unused property.

This PR will eliminate the use of innerBlockCount.
#56323

Why?

This results in cleaner code.

Screenshots or screencast

pattern

Detach and Manage work the same as before

Copy link

github-actions bot commented Jun 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Patterns /pacakges/patterns props-bot Manually triggers Props Bot to ensure the list of props is up to date. labels Jun 5, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Jun 5, 2025
@t-hamano t-hamano merged commit 8cfa39e into WordPress:trunk Jun 5, 2025
70 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 5, 2025
@shimotmk shimotmk deleted the fix/delete-unused-property branch June 5, 2025 04:21
@talldan talldan changed the title Fix delete unused property Patterns: delete unused property Jun 25, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
* fix/delete-unused-property

* fix/delete-unused-property

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Patterns /pacakges/patterns [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants