Skip to content

Fix parameter hint for canInsertBlocks #70305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

Fix parameter hint for canInsertBlocks #70305

merged 3 commits into from
Jun 4, 2025

Conversation

aurooba
Copy link
Member

@aurooba aurooba commented Jun 3, 2025

What?

Small fix. The clientIds parameter of canInsertBlocks expects an array of strings, rather than just a string. Reference:

gutenberg/packages/block-editor/src/store/selectors.js

Lines 1816 to 1820 in a5e3592

export function canInsertBlocks( state, clientIds, rootClientId = null ) {
return clientIds.every( ( id ) =>
canInsertBlockType( state, getBlockName( state, id ), rootClientId )
);
}

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aurooba <aurooba@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aurooba aurooba added the [Type] Developer Documentation Documentation for developers label Jun 3, 2025
@aurooba aurooba self-assigned this Jun 3, 2025
@aurooba aurooba requested a review from ellatrix as a code owner June 3, 2025 21:03
t-hamano
t-hamano approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 4, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jun 4, 2025
@t-hamano t-hamano added the [Package] Block editor /packages/block-editor label Jun 4, 2025
@t-hamano t-hamano merged commit 30778d0 into WordPress:trunk Jun 4, 2025
76 of 77 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone Jun 4, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@aurooba @t-hamano @chriszarate
Fix parameter hint for canInsertBlocks (WordPress#70305)
f003735 
* Fix parameter hint for `canInsertBlocks`

* ran `npm run docs:api-ref`

* adjust param in doc block and run docs command

Co-authored-by: aurooba <aurooba@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@ndiego ndiego Awaiting requested review from ndiego ndiego is a code owner

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees

@aurooba aurooba

Labels
[Package] Block editor /packages/block-editor [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aurooba @t-hamano