iAPI: Fix captured errors in withScope generators
#70303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +28 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
luisherranz
requested changes
Jun 3, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
f5e7d6e to
9f9105a
Compare
|
@luisherranz, changelog updated! |
10 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Add failing test * Fix error handling in withScope generator * Allow generators to throw * Throw for returned rejected promises * Add unit tests for withScope * Remove duplicated tests * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue in the
withScopefunction when it creates wrappers around async actions and callbacks defined in a store. In particular, the wrapper passes the wrong value to the generator in ayieldoperator that appears after an error is caught.Also, other fixes related to errors have been addressed:
nextorthrowfunctions are called and they throw an error. This is the equivalent of an uncaught error in the generator's code.return) is a rejected promise, similar to async functions.Why?
Async functions in the store should properly allow error handling.
Testing Instructions
E2E and unit tests have been added.