Social Link: Use placement prop for popover positioning
#70348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
22 tasks
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…70348) Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #44401
This PR updates the Dropdown component within the Social Link block to use the
placementprop instead of the deprecatedpositionprop for its popover.Why?
The
positionprop for the Popover component (used internally by Dropdown) has been deprecated in favor of placement. This change aligns the Social Link block with the current component API, ensuring future compatibility and preventing potential warnings or bugs related to deprecated code.How?
Replaced
popoverProps.positionwithpopoverProps.placementin the SocialLinkEdit component. Thebottom-startvalue is the modern equivalent of the previous positioning.Testing Instructions
contentOnlymode is enabled and the labels are enabled (enableShow text)Texttext on the right of the social logoScreencasts