Skip to content

Image: Fix outdated accessibility hint on native component #70346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Image: Fix outdated accessibility hint on native component #70346

merged 1 commit into from
Jun 6, 2025

Conversation

yashjawale
Copy link
Contributor

What?

This PR fixes the outdated accessiblity hint in native image component.

It was agreed to solve this issue in two steps in the issue discussion...

  1. Update the hint to Double tap to view larger. to avoid confusion with the hold to edit message.
  2. Introduce dynamic accessibility hints that consider the media states.

See #45124

Why?

Since the long press event was disabled in PR #40651

The current hint Double tap and hold to edit. is no longer relevant & needs to be replaced by Double tap to view larger.

How?

This PR completes step 1 of the fix

Next step will be to add dynamic hints according to media states

Testing Instructions [on mobile]

  1. Add an Image or Media & Text block.
  2. Add media to the block.
  3. Enable Voice Over.
  4. Move focus to the image.

Screenshots or screencast

image

Tested with iOS simulator, with iPhone 16 Plus iOS 18.5

Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yashjawale <yashjawale@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @yashjawale! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@yashjawale yashjawale changed the title fix: update double tap hint in native image component Image: Fix outdated accessibility hint on native component Jun 6, 2025
@dcalhoun dcalhoun self-assigned this Jun 6, 2025
dcalhoun
dcalhoun approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @yashjawale! The proposed changes make sense and accomplish the first of the two changes referenced in #45124 (comment).

In the name of transparency, I'll share that development of the native mobile editor (Gutenberg Mobile) is currently in a hiatus. We are exploring a different, WebView-based approach in GutenbergKit.

I'll merge this improvement, but wanted to note that it is unlikely to be published in an new editor release for the foreseeable future.

Regardless, thank you, again, for helping move the project forward. 🙇🏻‍♂️

@dcalhoun dcalhoun merged commit faa2c90 into WordPress:trunk Jun 6, 2025
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.1 milestone Jun 6, 2025
@yashjawale
Copy link
Contributor Author

Thanks for the updated information 🙌🙇‍♂️
I'll check out GutenbergKit, it looks interesting! 🚀

@talldan talldan added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block labels Jun 25, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@yashjawale @chriszarate
fix: update double tap hint in native image component (WordPress#70346)
186e809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees

@dcalhoun dcalhoun

Labels
[Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 21.1
Development

Successfully merging this pull request may close these issues.
3 participants
@yashjawale @dcalhoun @talldan