Skip to content

Conversation

pmbaldha
Copy link
Contributor

What?

Closes #70230

Why?

Instead of writing custom HTML for the admin notice, we should call the wp_admin_notice() function.
https://developer.wordpress.org/reference/functions/wp_admin_notice/

Copy link

github-actions bot commented May 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pmbaldha <pmbaldha@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@pmbaldha pmbaldha marked this pull request as draft May 27, 2025 16:11
@pmbaldha pmbaldha marked this pull request as ready for review May 27, 2025 16:16
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label May 27, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pmbaldha!

@Mamaduka Mamaduka added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label May 27, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label May 27, 2025
@Soean Soean merged commit 9935804 into WordPress:trunk May 27, 2025
84 of 105 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 27, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The wp_admin_notice() function should be called instead of custom HTML for admin notice in docs/how-to-guides/notices/README.md
3 participants