Skip to content

List Block: Remove unused __unstableMultilineWrapperTags field from block.json #70209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

List Block: Remove unused __unstableMultilineWrapperTags field from block.json #70209

merged 2 commits into from
Jul 7, 2025

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented May 25, 2025 •
edited
Loading

Related to:

What?

The multiline field was previously necessary when using the multiline prop in the RichText component. However, since both the List and Quote blocks now use InnerBlocks, this field is no longer necessary.

As for the __unstableMultilineWrapperTags field, its processing has been removed here and it has no role.

Why?

Code quality.

Testing Instructions

Nothing.

@t-hamano t-hamano self-assigned this May 25, 2025
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Block] List Affects the List Block [Block] Quote Affects the Quote Block labels May 25, 2025
@t-hamano t-hamano marked this pull request as ready for review May 25, 2025 08:22
@github-actions GitHub Actions
Copy link

github-actions bot commented May 25, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano force-pushed the list-remove-unused-attr branch from 6c175f5 to fee3e77 Compare July 1, 2025 09:57
fabiankaegy
fabiankaegy approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find :)

@t-hamano t-hamano force-pushed the list-remove-unused-attr branch from fee3e77 to 2081bfa Compare July 7, 2025 08:44
@t-hamano t-hamano force-pushed the list-remove-unused-attr branch from 2081bfa to ca7195b Compare July 7, 2025 08:45
@t-hamano t-hamano changed the title List Block, Quote Block: Remove unused multiline field from block.json List Block: Remove unused __unstableMultilineWrapperTags field from block.json Jul 7, 2025
@t-hamano t-hamano removed the [Block] Quote Affects the Quote Block label Jul 7, 2025
@t-hamano
Copy link
Contributor Author

t-hamano commented Jul 7, 2025

@fabiankaegy Thanks for the review!

Removing the multiline field caused some unit tests to fail, so I restored it. It's probably needed for migrating old markup. In this PR, let's only remove the __unstableMultilineWrapperTags field that doesn't exist in the codebase.

@t-hamano t-hamano merged commit 7cc59e5 into trunk Jul 7, 2025
126 of 134 checks passed
@t-hamano t-hamano deleted the list-remove-unused-attr branch July 7, 2025 10:40
@github-actions github-actions bot added this to the Gutenberg 21.2 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@t-hamano t-hamano

Labels
[Block] List Affects the List Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 21.2
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @fabiankaegy