ImageSizeControl: Use margin-free style #70202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -73 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
May 25, 2025
Comment on lines
+26
to
+27
| .block-editor-html-element-control, | ||
| .block-editor-image-size-control { |
There was a problem hiding this comment.
These styles should be removed in the feature. See #65191
|
Flaky tests detected in 2c6de60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/15233670448
|
Mamaduka
approved these changes
May 27, 2025
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while reviewing #70200
What?
Remove the margin styles from the
ImageSizeControlcomponent and apply a grid layout.Why?
The current implementation doesn't fit when this component is used inside the
ToolsPanelItemcomponent. This is because it resets margins as much as possible. As a result, as this comment says, we cannot maintain the layout within aToolsPanelItem.Furthermore, the style based on the
emunits doesn't match Gutenberg's UI design.How?
.block-editor-image-size-controlCSS class to the root of the component.Testing Instructions
Screenshots or screencast
The visual change is subtle, but all spacing is now standardized to 16px.