Update icons: Help, PlusCircle, Typography #70299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Size Change: +404 B (+0.02%) Total Size: 1.87 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jun 4, 2025
| @@ -5,7 +5,11 @@ import { SVG, Path } from '@wordpress/primitives'; | |||
|
|
|||
| const plusCircle = ( | |||
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="-2 -2 24 24"> | |||
| <Path d="M10 1c-5 0-9 4-9 9s4 9 9 9 9-4 9-9-4-9-9-9zm0 16c-3.9 0-7-3.1-7-7s3.1-7 7-7 7 3.1 7 7-3.1 7-7 7zm1-11H9v3H6v2h3v3h2v-3h3V9h-3V6zM10 1c-5 0-9 4-9 9s4 9 9 9 9-4 9-9-4-9-9-9zm0 16c-3.9 0-7-3.1-7-7s3.1-7 7-7 7 3.1 7 7-3.1 7-7 7zm1-11H9v3H6v2h3v3h2v-3h3V9h-3V6z" /> | |||
| <Path | |||
| fillRule="evenodd" | |||
There was a problem hiding this comment.
I always wonder if we need these rules. Assume we do.
| @@ -5,7 +5,11 @@ import { SVG, Path } from '@wordpress/primitives'; | |||
|
|
|||
| const plusCircle = ( | |||
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="-2 -2 24 24"> | |||
There was a problem hiding this comment.
The viewbox here is wrong. It should be 0 0 24 24.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Jun 4, 2025
|
We should, yes! Good eye. I took as tab in this Figma file. Here's a before and after: |
|
Yes there is a big group of circular icons that need updating. I probably won't get to those in the near term though. Up to y'all if we want to merge this, or wait for a comprehensive PR that targets all circular icons. |
If all circular icons will ultimately be unified, I think it's fine to merge as is. Regarding the |
|
I'm going to merge this one and follow up with the remaining icons. |
|
Actually, I'll add a changelog to this one first :) |
746d95b to
59a89c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the following icons:
Why?
Testing Instructions
npm run storybookScreenshots