Skip to content

Conversation

Sukhendu2002
Copy link
Contributor

@Sukhendu2002 Sukhendu2002 commented May 12, 2025

What?

Part of: #65778

This PR fixes an issue with the More block where users cannot edit the "Read more" text when the block is in contentOnly mode.

How?

Added role: "content" to the customText attribute in the More block's block.json file to explicitly mark it as editable content even in restricted editing modes.

Testing Instructions

  1. Create a Group block
  2. Set the Group block's templateLock attribute to "contentOnly"
  3. Insert a More block inside this Group
  4. Try to edit the "Read more" text

Screenshots or screencast

Screen.Recording.2025-05-12.at.5.48.32.PM.mov

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review May 12, 2025 12:23
Copy link

github-actions bot commented May 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I agree that the read more text should be editable in contentOnly mode.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Block] More Affects the More Block - used for displaying the 'Read More' link props-bot Manually triggers Props Bot to ensure the list of props is up to date. labels May 13, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label May 13, 2025
@t-hamano t-hamano merged commit 406af5f into WordPress:trunk May 13, 2025
93 of 115 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 13, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] More Affects the More Block - used for displaying the 'Read More' link [Feature] Write mode [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants