Editor: Better normalize strings for hierarchical term filtering #70178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +32 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
This comment was marked as outdated.
This comment was marked as outdated.
da0f9ed to
6da7238
Compare
6da7238 to
428f0e4
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
May 28, 2025
There was a problem hiding this comment.
LGTM! Works fine for both half-width and full-width character searches.
Before
| Filter by half-width characters | Filter by full-width characters |
|---|---|
After
| Filter by half-width characters | Filter by full-width characters |
|---|---|
- Do we add a changelog entry about exposing the
normalizeTextStringfunction as a private API? - I think
FlatTermSelectorneeds to be fixed as well to fully resolve #70169.
This might be a regression introduced by #70180. It seems that it is no longer possible to search using full-width characters in the ✅Filtering by half-width characters ❌ Filtering by full-width characters I'm trying to fix it with #70232. |
|
Odd, I thought we fixed the |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…dPress#70178) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: fumikito <takahashi_fumiki@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70169.
Related #70180.
PR improves unitcode handling when searching hierarchical terms in the editor.
Why?
See #70169.
How?
Expose
normalizeTextStringas a private API and use it for text normalization in the filter matcher.Testing Instructions
PlayStation 2andＰｌａｙＳｔａｔｉｏｎ ２. Note: Copy the names.Testing Instructions for Keyboard
Same.
Screenshots or screencast
CleanShot.2025-05-27.at.17.14.55.mp4