Skip to content

Shortcode: Add role attribute to content in block.json #70164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Shortcode: Add role attribute to content in block.json #70164

merged 1 commit into from
May 23, 2025

Conversation

SainathPoojary
Copy link
Contributor

What?

Part of: #65778

Why?

This PR enhances the editing experience of Shortcode block in contentOnly mode

Testing Instructions

  1. Create a Group block
  2. Set the Group block's templateLock attribute to contentOnly
  3. Insert the Shortcodel block inside the group
  4. Verify that you can edit the content

Screenshots or screencast

Screen.Recording.2025-05-20.at.12.25.36.AM.mov

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Block] Shortcode Affects the Shortcode Block labels May 20, 2025
Mamaduka
Mamaduka approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SainathPoojary!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 23, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 23, 2025
@Mamaduka Mamaduka merged commit dc21d96 into WordPress:trunk May 23, 2025
69 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.0 milestone May 23, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@SainathPoojary @Mamaduka @chriszarate
Shortcode: Add role attribute to content in block.json (WordPress#7…
ab1c8dc 
…0164)

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Shortcode Affects the Shortcode Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SainathPoojary @Mamaduka @Soean