Skip to content

Plugin: Bump minimum required WordPress version to 6.7 #70023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

Plugin: Bump minimum required WordPress version to 6.7 #70023

merged 6 commits into from
May 1, 2025

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Apr 30, 2025 •
edited
Loading

What?

Similar to #67117.

PR bumps the "Required WP version" field to 6.7, and the "Tested up to" field to 6.8. It also updates the performance test base hash.

Why?

The plugin only supports the last two major WP versions (plus trunk)

How?

See https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit.

Testing Instructions

CI checks are green.

@Mamaduka Mamaduka added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Apr 30, 2025
@Mamaduka Mamaduka self-assigned this Apr 30, 2025
@Mamaduka Mamaduka requested a review from desrosj as a code owner April 30, 2025 14:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Flaky tests detected in bc71b23.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14756856376
📝 Reported issues:

@Mamaduka Mamaduka added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Apr 30, 2025
@Mamaduka
Copy link
Member Author

@desrosj, the core commit for Gutenberg version needs to occur after this change is included in the plugin RC, correct? Ref: #67117 (comment).

@desrosj
Copy link
Member

desrosj commented Apr 30, 2025

The bump in Core SVN can happen at any time because the previous X.Y version of the plugin has already been released. But ideally, we should be confident that the final bug release for the last X.Y plugin version supporting that branch has been published to avoid having to update Core SVN twice.

@Mamaduka
Copy link
Member Author

Thanks, @desrosj! I'll prepare the core ticket/patch tomorrow.

@Mamaduka Mamaduka requested a review from t-hamano April 30, 2025 19:28
t-hamano
t-hamano approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Smoke tested on WordPress 6.7
  • I've run some e2e tests locally, and confirmed that no PHP errors occurred by removing the back compat code.

@Mamaduka
Copy link
Member Author

Mamaduka commented May 1, 2025

I'm going to merge this. Create a track ticket and finish the remaining items there: https://core.trac.wordpress.org/ticket/63377#ticket.

@Mamaduka Mamaduka merged commit 1fea5e7 into trunk May 1, 2025
63 checks passed
@Mamaduka Mamaduka deleted the update/minimum-wp-version-to-6-7 branch May 1, 2025 08:39
@github-actions github-actions bot added this to the Gutenberg 20.8 milestone May 1, 2025
Mamaduka
Mamaduka commented May 3, 2025
View reviewed changes
.github/workflows/performance.yml
@@ -76,13 +76,14 @@ jobs:
- name: Compare performance with base branch
if: github.event_name == 'push'
# The base hash used here need to be a commit that is compatible with the current WP version
# The current one is c7722262e65a3f4d0f1a2d1ad29eccb2069509e4 and it needs to be updated every WP major release.
# The current one is 177c166a5eada898ad015f5efaf1c6fefa7042c4 and it needs to be updated every WP major release.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to use a different SHA; this doesn't work as expected, and I don't see new commits in CodeVitals.

@Mamaduka Mamaduka mentioned this pull request May 3, 2025
Merged
@Mamaduka Mamaduka mentioned this pull request May 28, 2025
Closed
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@Mamaduka @t-hamano
@desrosj @chriszarate
Plugin: Bump minimum required WordPress version to 6.7 (WordPress#70023)
6ff6c5c 
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@desrosj desrosj Awaiting requested review from desrosj desrosj is a code owner

@dmsnell dmsnell Awaiting requested review from dmsnell dmsnell is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@Mamaduka Mamaduka

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core
Projects
None yet
Milestone
Gutenberg 20.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @desrosj @t-hamano