Simplify color specifications from rgba to rgb
#70008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the theme.json that ships in core at `wp-includes/theme.json` default gradients are inconsistent in color specification -- a number of places it uses `rgba(#,#,#,1)` even though that is equivalent to just `rgb(#,#,#)` -- there is no rhyme or reason I can see as to why rgba is used here, so this is to trim a couple bytes by serving them up as rgb instead of rgba. As there is no transparency here, it may be slightly more efficient to use hex? But I'm fine leaving it as RGB for less code churn in core unless anyone feels strongly here.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
cc @WordPress/block-themers |
juanfra
reviewed
Apr 30, 2025
|
Happy to see us switch over to it -- especially as hex now supports alpha transparency if needed. |
Mamaduka
approved these changes
Apr 30, 2025
|
@georgestephanis Thanks for working on this! Do you have the bandwidth to submit a core ticket and patch? The |
|
Sure, I'll get it in today. |
|
Trac ticket that ^^ is for: |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
May 13, 2025
…on`. `rgba(#,#,#,1)` is equivalent to `rgb(#,#,#)` and can be replaced with the latter for more consistency. Original PR from Gutenberg repository: * [WordPress/gutenberg#70008 #70008 Simplify color specifications from rgba to rgb] Follow-up to [50959], [55405]. Props georgestephanis, wildworks, juanfra. Fixes #63381. git-svn-id: https://develop.svn.wordpress.org/trunk@60234 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 13, 2025
…on`. `rgba(#,#,#,1)` is equivalent to `rgb(#,#,#)` and can be replaced with the latter for more consistency. Original PR from Gutenberg repository: * [WordPress/gutenberg#70008 #70008 Simplify color specifications from rgba to rgb] Follow-up to [50959], [55405]. Props georgestephanis, wildworks, juanfra. Fixes #63381. Built from https://develop.svn.wordpress.org/trunk@60234 git-svn-id: http://core.svn.wordpress.org/trunk@59570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
May 13, 2025
…on`. `rgba(#,#,#,1)` is equivalent to `rgb(#,#,#)` and can be replaced with the latter for more consistency. Original PR from Gutenberg repository: * [WordPress/gutenberg#70008 #70008 Simplify color specifications from rgba to rgb] Follow-up to [50959], [55405]. Props georgestephanis, wildworks, juanfra. Fixes #63381. Built from https://develop.svn.wordpress.org/trunk@60234 git-svn-id: https://core.svn.wordpress.org/trunk@59570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Simplify color specifications from `rgba` to `rgb` Currently, the theme.json that ships in core at `wp-includes/theme.json` default gradients are inconsistent in color specification -- a number of places it uses `rgba(#,#,#,1)` even though that is equivalent to just `rgb(#,#,#)` -- there is no rhyme or reason I can see as to why rgba is used here, so this is to trim a couple bytes by serving them up as rgb instead of rgba. As there is no transparency here, it may be slightly more efficient to use hex? But I'm fine leaving it as RGB for less code churn in core unless anyone feels strongly here. * Update test to account for changed default. Co-authored-by: georgestephanis <georgestephanis@git.wordpress.org> Co-authored-by: juanfra <juanfra@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the theme.json that ships in core at
wp-includes/theme.jsondefault gradients are inconsistent in color specification -- a number of places it usesrgba(#,#,#,1)even though that is equivalent to justrgb(#,#,#)-- there is no rhyme or reason I can see as to why rgba is used here, so this is to trim a couple bytes by serving them up as rgb instead of rgba.As there is no transparency here, it may be slightly more efficient to use hex? But I'm fine leaving it as RGB for less code churn in core unless anyone feels strongly here.
Why?
Simplifying color specifications in core boilerplates -- more consistency in code style standards.
How?
Dropping the opacity specification when it's full opacity.
Testing Instructions