Fix: Improve warning message and add spacing in HTMLElementControl #70002
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks for the PR!
- Improves the warning message shown when duplicate
<main>elements are detected, clarifying that the duplicate may be in the page template as well as in the content.- Improves spacing
Both of these have worked fine for me.
@Mamaduka @luminuu @carolinan Any other feedback?
There was a problem hiding this comment.
I think the warning message can be simplified; otherwise, everything looks good.
Thanks, @Sukhendu2002!
| @@ -11,7 +11,8 @@ | |||
| } | |||
|
|
|||
| .components-base-control, | |||
| .components-radio-control { | |||
| .components-radio-control, | |||
| .block-editor-html-element-control { | |||
There was a problem hiding this comment.
I hope we can eliminate these special classes in the future, but for now, it makes sense to group them.
@WordPress/gutenberg-components, do we have an issue to modernize block inspector controls styling now that most components have migrated to __nextHasNoMarginBottom?
There was a problem hiding this comment.
There is a suggestion to unify the layout of the block inspector. These styles should be removed in the future.
packages/block-editor/src/components/html-element-control/index.js
Outdated
Show resolved
Hide resolved
…ordPress#70002) * Fix: Improve warning message and add bottom margin in HTMLElementControl * Simplify warning message Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
Follow up: #69904 (comment)
This PR makes two small improvements to the
HTMLElementControlcomponent:<main>elements are detected, clarifying that the duplicate may be in the page template as well as in the content.Screenshots or screencast