Skip to content

Remove "global" from styles variation in schema descriptions #70089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

unscripted
Copy link
Member

What?

This PR updates the description for the title, slug, and description properties in the theme.json schema.

Since this schema is now used for global style variations and block style variations, removing the term "global" makes the description universal.

Testing Instructions

  1. Open a WordPress project in VS Code or a similar editor.
  2. Add or update a theme.json to include the title, slug, and description parameters.
  3. Update the schema to point to the updated file.
  4. Hover over the property to reveal the schema hint.

"$schema": "../../plugins/gutenberg/schemas/json/theme.json", or similar.

Copy link

github-actions bot commented May 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: unscripted <cwhitmore@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels May 9, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you, @unscripted!

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 9, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label May 9, 2025
@Mamaduka Mamaduka merged commit 523c3ba into WordPress:trunk May 9, 2025
69 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 9, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ss#70089)

Co-authored-by: unscripted <cwhitmore@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants