Editor: Honor rich/code editor settings when deriving the editor mode #70080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d74fd26. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14890900355
|
t-hamano
approved these changes
May 8, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @CreativeDive. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @Mamaduka, I have tested the PR and it solves the issue 👍. |
|
Thanks for testing, everyone! @t-hamano, I think it makes sense for the Site Editor to override that setting; it's not very useful without visual editing. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#70080) Unlinked contributors: CreativeDive. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: kraftner <kraftner@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #49211.
PR updates logic in the
EditorInterfacecomponent to userichEditingEnabledandcodeEditingEnabledsettings when deriving the editor's mode.The
editorModeis a persistent global setting, and we shouldn't change it during editor initialization.This matches the logic in the
ModeSwitchercomponent:gutenberg/packages/editor/src/components/mode-switcher/index.js
Lines 49 to 55 in 2659405
Why?
See #49211.
Testing Instructions
page(see snippet below).post.page.Testing Instructions for Keyboard
Same.
Screenshots or screencast