Skip to content

Workflows: Add option for publishing the latest npm packages #70079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented May 7, 2025

What?

PR updates the "Publish npm packages" workflow and adds the option to publish the latest Gutenberg release packages to NPM. This is similar to the package publishing step in the Gutenberg plugin release process.

Why?

Action is helpful if package publishing fails during plugin release and allows for "manual" publishing.

Testing Instructions

We need to run the actual workflow after the PR is merged.

@Mamaduka Mamaduka self-assigned this May 7, 2025
@Mamaduka Mamaduka requested a review from desrosj as a code owner May 7, 2025 14:41
@Mamaduka Mamaduka added the [Type] Build Tooling Issues or PRs related to build tooling label May 7, 2025
Copy link

github-actions bot commented May 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@@ -53,7 +54,7 @@ jobs:
ref: trunk
token: ${{ secrets.GUTENBERG_TOKEN }}
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
persist-credentials: false
persist-credentials: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #70007, which only updated one case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need credentials as Lerna adds commits and branches during npm publishing preparation process.

@Mamaduka Mamaduka requested review from johnbillion and gziolo May 7, 2025 14:42
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming the changes we discussed with @Mamaduka look good.

It would be also great to add a note at the very end of this section:

Synchronizing the Gutenberg plugin when this manual publishing works as expected so we have the backup plan documented whenever the publishing automated with the Gutenberg plugin fails as last time.

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
@Mamaduka
Copy link
Member Author

Mamaduka commented May 7, 2025

Thank you, @gziolo! I'm going to merge this and update the documentation once we're sure the update works as expected.

@Mamaduka Mamaduka merged commit 7c641cf into trunk May 7, 2025
60 checks passed
@Mamaduka Mamaduka deleted the try/publishing-packages-allow-latest branch May 7, 2025 16:28
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 7, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ss#70079)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants