-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Workflows: Add option for publishing the latest npm packages #70079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -53,7 +54,7 @@ jobs: | |||
ref: trunk | |||
token: ${{ secrets.GUTENBERG_TOKEN }} | |||
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} | |||
persist-credentials: false | |||
persist-credentials: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #70007, which only updated one case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need credentials as Lerna adds commits and branches during npm publishing preparation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming the changes we discussed with @Mamaduka look good.
It would be also great to add a note at the very end of this section:
Synchronizing the Gutenberg plugin when this manual publishing works as expected so we have the backup plan documented whenever the publishing automated with the Gutenberg plugin fails as last time.
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
Thank you, @gziolo! I'm going to merge this and update the documentation once we're sure the update works as expected. |
…ss#70079) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
What?
PR updates the "Publish npm packages" workflow and adds the option to publish the latest Gutenberg release packages to NPM. This is similar to the package publishing step in the Gutenberg plugin release process.
Why?
Action is helpful if package publishing fails during plugin release and allows for "manual" publishing.
Testing Instructions
We need to run the actual workflow after the PR is merged.