Skip to content

Site Editor: Fix PHP warnings in gutenberg_get_site_editor_redirection #70062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

karthikeya-io
Copy link
Contributor

@karthikeya-io karthikeya-io commented May 6, 2025

What?

Closes #70060

Fixes a PHP warning when opening the Site Editor with the Gutenberg plugin active. These warnings can be reproduced in WordPress Studio environment

How?

Backport from WP Core https://core.trac.wordpress.org/changeset/60135

Testing Instructions

  1. Use the WP studio development environment
  2. Open Site Editor (Appearance > Editor)
  3. Confirm that there are no warnings.

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This PR is in draft state, but I think it's ready to ship as is.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core labels May 6, 2025
@t-hamano t-hamano marked this pull request as ready for review May 6, 2025 10:54
@t-hamano t-hamano requested a review from spacedmonkey as a code owner May 6, 2025 10:54
Copy link

github-actions bot commented May 6, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthikeya-io <karthikeya01@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org>
Co-authored-by: amitb1991 <amitbhosale@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthikeya-io
Copy link
Contributor Author

Thanks @t-hamano for reviewing the PR. 🙇

@t-hamano t-hamano merged commit 8b7b04a into WordPress:trunk May 6, 2025
70 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.9 milestone May 6, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: karthikeya-io <karthikeya01@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: sabernhardt <sabernhardt@git.wordpress.org>
Co-authored-by: amitb1991 <amitbhosale@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning messages appear in UI the Appearance Editor when we activate Gutenberg
2 participants