Stylelint: Customise warning message for flex-direction warning
#70057
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the review @t-hamano , We have one more rule for Stylelint in 'declaration-property-value-disallowed-list': [
{
'/.*/': [ '/--wp-components-color-/' ],
},
{
message: ( property, value ) =>
`Avoid using "${ value }" in "${ property }". --wp-components-color-* variables are not ready to be used outside of the components package.`,
},
],I was wondering we can update this message as well, looking forward to your thoughts. |
Nice idea, feel free to ping me if a PR is ready👍 |
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
What?
Followup: #69590 (review)
The warning message shown previously was static. This PR aims to make the Stylelint warning related to non-usage of
row-reverse/column-reverseinflex-directiondynamic. This would improve the warnings and make them dynamic. first suggested in this issue #63090Originally reported here:
How?
After the Stylelint configuration was updated to JavaScript via #69590, now custom warnings can be shown for custom rules.
Testing Instructions
row/columntorow-reverse/column-reverse. In short append reverse.Screencast
Before
Screen.Recording.2025-05-05.at.4.54.50.PM.mov
After
Screen.Recording.2025-05-05.at.5.03.35.PM.mov