-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Button: Limit scope of width style for link #70054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -27 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
Just tested this and can confirm it works as described! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @t-hamano!
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release. I believe this PR should be backported to the 6.8.2 release since it is a regression that occurred in 6.8. |
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: luminuu <luminuu@git.wordpress.org>
This PR was cherry-picked into the |
Closes https://core.trac.wordpress.org/ticket/63373
Follow-up on #64770 and #69651
What?
This PR changes the style selector for buttons to this:
Why?
The
width: 100%
style is needed to stretch the buttons in the vertical layout. However, the.wp-block-button__link
selector resulted in forcing the button's width to 100% width even though the button was not a child of a flex layout, such as in the following HTML:This problem occurred in the Post Comments Form block, so we fixed the problem in #69651. However, it's possible that consumers are using this button selector in other places as well.
How?
Apply 100% width style to only the button links inside the buttons.
Testing Instructions