Skip to content

Keyboard Shortcuts: Revert delete shortcut to access + z #69931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Keyboard Shortcuts: Revert delete shortcut to access + z #69931

merged 1 commit into from
Apr 21, 2025

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Apr 18, 2025 •
edited
Loading

What?

Follow-up to #68139
Reverts #69074, #68164

This PR reverts the changes made in #69074 and #68164 to the delete keyboard shortcut.

Why?

There were concerns raised regarding accessibility and user experience with the use of Ctrl/Cmd + Shift + Backspace/Delete as the keyboard shortcut. ( Ref. #68139 (comment) )

How?

primaryShift + backspace was replaced with access + z as the new shortcut for removing the selected blocks.

Testing Instructions

  1. Create a new post.
  2. Add some blocks.
  3. Try deleting the blocks with the shortcut ctrl + option + z on macOS and shift + alt + z on Windows/Linux.
  4. Confirm the block deletion works as expected.

Testing Instructions for Keyboard

Same.

Screencast

pr-demo

new-shortcut

Note: Tested on MacOS, works as expected.

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review April 18, 2025 10:40
@yogeshbhutkar yogeshbhutkar requested a review from ellatrix as a code owner April 18, 2025 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Czab1, @tjarrettveracode.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Czab1, tjarrettveracode.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronjorbin aaronjorbin requested a review from t-hamano April 19, 2025 00:09
@aaronjorbin aaronjorbin added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Apr 19, 2025
@aaronjorbin aaronjorbin moved this to 🔎 Needs Review in WordPress 6.8.x Editor Tasks Apr 19, 2025
@t-hamano t-hamano linked an issue Apr 19, 2025 that may be closed by this pull request
Delete block shortcut: update to be more intuitive and farther from "undo" #68139
Closed
t-hamano
t-hamano approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's unfortunate, but based on user feedback it looks like we should revert to the original shortcuts 😅

Screenshot of the keyboard shortcuts modal on Windows:

image

Note: Storybook build failures are not caused by this PR.

@t-hamano t-hamano added the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Apr 19, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Apr 19, 2025 •
edited
Loading

Note: Storybook build failures are not caused by this PR.

I'm considering skipping this CI temporarily. See #69943

Update: #69943 has been merged. @yogeshbhutkar can you rebase this PR?

@yogeshbhutkar yogeshbhutkar force-pushed the revert-68139/delete-keyboard-shortcut branch from f1ad736 to 8c81e12 Compare April 21, 2025 03:58
@t-hamano t-hamano merged commit fe326a4 into WordPress:trunk Apr 21, 2025
59 checks passed
@t-hamano t-hamano moved this from 🔎 Needs Review to ✅ Done in WordPress 6.8.x Editor Tasks Apr 21, 2025
@github-actions github-actions bot added this to the Gutenberg 20.8 milestone Apr 21, 2025
@t-hamano t-hamano mentioned this pull request Apr 21, 2025
Closed
@yogeshbhutkar
Copy link
Contributor Author

Thanks for the review, @t-hamano.

t-hamano added a commit that referenced this pull request Apr 28, 2025
@yogeshbhutkar @t-hamano
@jarekmorawski @Mamaduka @talldan @joedolson
revert: make delete shortcut access + z (#69931)
a97b7ac 
Unlinked contributors: Czab1, tjarrettveracode.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
@t-hamano t-hamano mentioned this pull request Apr 28, 2025
Merged
@t-hamano
Copy link
Contributor

A backport PR for the wp/6.8 branch: #69998

t-hamano added a commit that referenced this pull request Apr 28, 2025
@yogeshbhutkar @t-hamano
@jarekmorawski @Mamaduka @talldan @joedolson
revert: make delete shortcut access + z (#69931)
ae79fcf 
Unlinked contributors: Czab1, tjarrettveracode.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
@t-hamano
Copy link
Contributor

Removing the Backport to WP Minor Release label as #69998 has just been merged into the wp/6.8 branch.

@t-hamano t-hamano removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Apr 28, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
@yogeshbhutkar @t-hamano
@jarekmorawski @Mamaduka @talldan @joedolson @chriszarate
revert: make delete shortcut access + z (WordPress#69931)
902a879 
Unlinked contributors: Czab1, tjarrettveracode.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
WordPress 6.8.x Editor Tasks
Status: ✅ Done
Milestone
Gutenberg 20.8
Development

Successfully merging this pull request may close these issues.

Delete block shortcut: update to be more intuitive and farther from "undo"
3 participants
@yogeshbhutkar @t-hamano @aaronjorbin