Create Block: Add --textdomain in create-block README
#69927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
reviewed
Apr 17, 2025
packages/create-block/README.md
Outdated
| With this argument, the `create-block` package will a generate a block with the provided text domain. If not specified, the block’s slug is used as the default text domain. | ||
|
|
||
| ```bash | ||
| $ npx @wordpress/create-block@latest block-name --textdomain=my-custom-domain |
There was a problem hiding this comment.
Suggested change
| $ npx @wordpress/create-block@latest block-name --textdomain=my-custom-domain | |
| $ npx @wordpress/create-block@latest --textdomain my-custom-domain |
Can we align this command with the other commands?
|
Hi @t-hamano, |
t-hamano
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the README.md to document the new
--textdomainflag that was added to thecreate-blocktool in the previous PR (#69802).Why?
The previous PR added support for the
--textdomainflag to the create-block tool, allowing users to specify a custom text domain for internationalization. This PR adds documentation to the README, ensuring users know how to use this new feature.