-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Block Editor: Prevent block merging on blocks with the 'disabled' editing mode. #69918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Prevent block merging on blocks with the 'disabled' editing mode. #69918
Conversation
This patch adds an additional check to the mergeBlocks action to prevent a block from being merged into a block that is disabled.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jrmd! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for contributing, @jrmd! I just realized that we also need to handle the forward delete case. Here are the reproduction steps:
|
Ahh thanks @Mamaduka I actually tried to see if that test case was valid using the accessibility keyboard but it didnt work; so TIL about fn+delete :) Updated the logic, and also added unit tests and fixed the failing unit tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing, @jrmd!
The fix works as expected ✅
…ting mode. (WordPress#69918) Co-authored-by: jrmd <jrmd@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
Closes #69915
This PR adds an additional check to the mergeBlocks action to prevent a block from being merged into a block that is disabled.
Why?
Blocks that are disabled shouldn't be able to be modified.
How?
Adds an extra check to the
mergeBlocks
action to check that the blocks current edit mode isn'tdisabled
Testing Instructions
Note
wp.data
needs to be exposed to run the console commandScreenshots or screencast
Before
Screen.Recording.2025-04-16.at.13.03.49.mov
After
Screen.Recording.2025-04-16.at.13.30.05.mov