-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Block Editor: Allow editing invalid blocks as HTML #69902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @aduth, @enriquesanchez. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cc4c55c
to
6bd3a2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for testing, @t-hamano! |
Unlinked contributors: aduth, enriquesanchez. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: ZebulanStanphill <zebulan@git.wordpress.org> Co-authored-by: azaozz <azaozz@git.wordpress.org> Co-authored-by: jordesign <jordesign@git.wordpress.org> Co-authored-by: johngodley <johnny5@git.wordpress.org>
What?
Closes #7743.
PR disables "Edit as HTML" for invalid blocks in favor of "Attempt recovery" as the primary action.
Why?
The "Edit as HTML" toggle doesn't work on
trunk
.I know that the issue suggests leaving the option available. Still, after the initial commit, I realized that it would delay invalid content feedback and leave blocks in HTML editing mode.
Testing Instructions
</p>
tag.Testing Instructions for Keyboard
Same.
Screenshots or screencast