Image: Avoid stale URL when reselecting the same image from the library #69985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bd06953. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14662018556
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @T4ngml. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Love this! <3 |
|
I am checking the PRs with the "Backport to WP Minor Release" label applied to clarify which PRs should be backported to the WordPress 6.8.2 release. The issue this PR fixes is not new for 6.8, but it is a very useful improvement, and I think it would be a good idea to include it in the 6.8.1 release. |
t-hamano
pushed a commit
that referenced
this pull request
Jun 30, 2025
…ry (#69985) Unlinked contributors: T4ngml. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ry (WordPress#69985) Unlinked contributors: T4ngml. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Mamaduka
added a commit
that referenced
this pull request
Jul 8, 2025
…ry (#69985) Unlinked contributors: T4ngml. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
|
This PR was cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69965.
PR removes the condition for preserving the
urlattribute when selecting the same image from Media Library, which can cause subtle bugs as described in the linked issue.The condition was initially introduced in #16125 to avoid resetting the image "Resolution" setting, but it's no longer necessary after #49982.
Testing Instructions
srcso that both blocks point to the same image.IDandsrcdon't match and click "Replace".srcURL.Testing Instructions for Keyboard
Same.