Skip to content

List View: Add E2E test to verify pasting block styles via keyboard #69979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yogeshbhutkar
Copy link
Contributor

What, Why, and How?

Follow-up to #69196
Related discussion #69196 (comment)

This PR adds an E2E Test which tests the keyboard shortcut cmd(ctrl)+option(alt)+v to paste styles from the List View.

Testing Instructions

  1. Run the following command in the terminal.
    npm run test:e2e-- test/e2e/specs/editor/various/list-view.spec.js:600

  2. Confirm that the test passes.

Testing Instructions for Keyboard

Same.

Screenshot

e2e

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review April 24, 2025 09:14
Copy link

github-actions bot commented Apr 24, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor Author

Hi @t-hamano,

Following up on our previous discussion, this PR adds an E2E test to cover the keyboard shortcut for pasting block styles.

P.S. The failing tests are not related to the changes proposed in the PR.

@Mamaduka Mamaduka added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Apr 25, 2025
@yogeshbhutkar yogeshbhutkar force-pushed the e2e-playwright/list-view-paste-styles branch from e4415a6 to d74b085 Compare April 25, 2025 11:06
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the follow-up.

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 30, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 30, 2025
@t-hamano t-hamano merged commit f33f63e into WordPress:trunk Apr 30, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.8 milestone Apr 30, 2025
@yogeshbhutkar yogeshbhutkar deleted the e2e-playwright/list-view-paste-styles branch April 30, 2025 04:17
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ordPress#69979)

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants