Revert Admin bar: Update the Edit Site link #69974
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I understand this does not solve the problem in core, which needs a Trac ticket - I do not see that a trac ticket for reverting has been opened already. But this is what I managed to do today. If this is not the correct method, feel free to close. |
There was a problem hiding this comment.
Thanks for the PR!
I have submitted a core ticket and a core patch. Can you link the core patch URL to this PR?
I think the rule of adding a backport changelog applies to minor releases as well as major ones.
| require __DIR__ . '/compat/wordpress-6.8/admin-bar.php'; | ||
| // Note: admin-bar.php (69271) was reverted in Gutenberg 20.8.0. See https://github.com/WordPress/gutenberg/pull/69974. |
There was a problem hiding this comment.
Why is this comment necessary?
There was a problem hiding this comment.
I added it because I knew this would not be the last change to this menu feature.
When I had to research the past changes, it was a bit of a pain to find all the history.
|
The related change for WordPress Core has landed - https://core.trac.wordpress.org/changeset/60193 |
|
@aaronjorbin / @t-hamano / @Mamaduka seems this one did not land into 20.8 RC, right? |
|
@Mamaduka, Is there any chance to include this PR in Gutenberg 20.8? I know the 20.8 RC has already been processed. |
|
I'll backport this before the stable release. Thanks for the ping. |
Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: Marc-pi <mdxfr@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: Marc-pi <mdxfr@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: Marc-pi <mdxfr@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
What?
Reverts #69271, the updated "Edit Site" link in the WordPress admin bar, based on feedback.
This PR removes the admin-bar.php file which contained the filter which updated the admin bar link.
It keeps the old changelog with the reference to the core ticket.
Partial for #63785
Why?
Based on feedback, the updated link, - which lead to the first page in the Site Editor and not the current template, caused disruption of user workflows.
Testing Instructions
If you are testing this on WordPress 6.8, there will be no change, since the removed file was added to the plugin to make the plugin compatible with 6.8.
On versions lower than 6.8:
Apply the PR.
Activate the Gutenberg plugin.
Activate a block theme.
Visit the front of the website while logged in, with the admin bar enabled.
Locate the "Edit Site" link in the admin bar and confirm that activating the link leads to the current template, in the Site Editor.