Skip to content

Calendar block: Disable edit as HTML support #69961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shimotmk
Copy link
Contributor

@shimotmk shimotmk commented Apr 22, 2025

What?

This PR disables HTML editing support for Calendar blocks.

Why?

Dynamic blocks do not require HTML editing. Editing the HTML will break the blocks.

before.mp4

Make it consistent with other dynamic blocks

Testing Instructions

  1. Open a Post or Page.
  2. Insert a Calendar block.
  3. Confirm "Edit as HTML" action isn't available in block Options.

Screenshots or screencast

Before After
before after

Copy link

github-actions bot commented Apr 22, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shimotmk shimotmk changed the title Calendar Icons: Disable edit as HTML support Calendar block: Disable edit as HTML support Apr 22, 2025
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Calendar Affects the Calendar Block labels Apr 22, 2025
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @shimotmk!

The change here makes sense and matches other core blocks that use the ServerSideRender component.

@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 22, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 22, 2025
@Mamaduka Mamaduka merged commit d855dc0 into WordPress:trunk Apr 22, 2025
68 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.8 milestone Apr 22, 2025
@shimotmk shimotmk deleted the fix/calendar-disable-html-editing branch April 22, 2025 21:04
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: shimotmk <shimotomoki@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendar Affects the Calendar Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants