Use split view for meta boxes only when canvas is iframed and “Desktop” view #69958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7631986.
sc0ttkclark
approved these changes
Apr 21, 2025
|
Size Change: -30 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
stokesman
commented
Apr 21, 2025
There was a problem hiding this comment.
Just noting that in #66706 a couple of changes that weren’t strictly necessary are reverted here. One should be functionally harmless to revert #66706 (comment). The other may create an obscure issue #66706 (comment) and would be nice to follow up with an isolated fix.
t-hamano
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Thanks for the PR!
Although this PR is still in draft status, this PR works fine for me.
However, this PR introduces another bug in tablet or mobile view, reported as part of #66629. This means that parts of the editor will be hidden when in tablet or mobile view.
trunk
There is a space between the editor and the meta box
This PR
Part of the editor overlaps with the meta box
Perhaps we may need to restore the CSS for is-scrollable.
Perhaps we need to port #68902 into trunk. I suppose that can be done as part of this PR. Before this PR, I did experiment with a partial revert (keeping the |
Cherry picked from 2a8dc37 on branch wp/6.7 --------- Conflicts: packages/edit-post/src/components/layout/index.js
|
I’ve cherry picked 2a8dc37 into this branch. I had to resolve conflicts. It appears to work as expected from my light testing. Adding that commit makes this more than a revert. That seems okay to me but if anyone has a reason we should split this up I'm open to doing that. If we proceed as is, I will update the title/description for clarity. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @thekendog, @jpmuldoon, @Traxus, @akmyta, @tsimshatsui, @robmcclel, @tatof, @kubixz39, @cucocreative, @ddryo, @daniellacatus. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
As I understand it, this PR will make the meta box work exactly the same as it did in WordPress 6.7. Is my understanding correct? In other words, this PR will change the meta box behavior as follows:
As an aside, I discovered a strange behavior in the device preview. When I was moving my mouse on the editor, the bottom margin of the editor suddenly disappeared. This seems to have been occurring on WordPress 6.7 as well, so it's not a blocker. 94e90bf6f352aaa09850ab4cbe7fafac.online-video-cutter.com.mp4 |
t-hamano
approved these changes
Apr 27, 2025
There was a problem hiding this comment.
I’ve cherry picked 2a8dc37 into this branch. I had to resolve conflicts. It appears to work as expected from my light testing.
Adding that commit makes this more than a revert. That seems okay to me but if anyone has a reason we should split this up I'm open to doing that. If we proceed as is, I will update the title/description for clarity.
I don't think there's any need to split this up. For now, let's just revert fully to the way it works in 6.7 and continue iterating on the Gutenberg plugin.
Hopefully, we can cherry-pick this PR into the 6.8 branch without conflicts.
|
Flaky tests detected in 7f4de83. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14690228458
|
t-hamano
added a commit
that referenced
this pull request
Apr 28, 2025
…p” view (#69958) * Revert "Split view with meta boxes even with legacy canvas (#66706)" This reverts commit 7631986. * Keep meta boxes unsplit from content in device previews Cherry picked from 2a8dc37 on branch wp/6.7 --------- Conflicts: packages/edit-post/src/components/layout/index.js Unlinked contributors: thekendog, jpmuldoon, Traxus, akmyta, tsimshatsui, robmcclel, tatof, kubixz39, cucocreative, ddryo, daniellacatus. Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org>
|
A backport PR for the |
t-hamano
added a commit
that referenced
this pull request
Apr 28, 2025
…p” view (#69958) * Revert "Split view with meta boxes even with legacy canvas (#66706)" This reverts commit 7631986. * Keep meta boxes unsplit from content in device previews Cherry picked from 2a8dc37 on branch wp/6.7 --------- Conflicts: packages/edit-post/src/components/layout/index.js Unlinked contributors: thekendog, jpmuldoon, Traxus, akmyta, tsimshatsui, robmcclel, tatof, kubixz39, cucocreative, ddryo, daniellacatus. Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org>
t-hamano
added a commit
that referenced
this pull request
Apr 28, 2025
…p” view (#69958) (#69996) * Revert "Split view with meta boxes even with legacy canvas (#66706)" This reverts commit 7631986. * Keep meta boxes unsplit from content in device previews Cherry picked from 2a8dc37 on branch wp/6.7 --------- Conflicts: packages/edit-post/src/components/layout/index.js Unlinked contributors: thekendog, jpmuldoon, Traxus, akmyta, tsimshatsui, robmcclel, tatof, kubixz39, cucocreative, ddryo, daniellacatus. Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org>
|
Removing the |
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#70000 - WordPress/gutenberg#69998 - WordPress/gutenberg#70001 - WordPress/gutenberg#70006 - WordPress/gutenberg#69958 Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: Yogesh Bhutkar <yogesh.bhutkar@rtcamp.com> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: jarekmorawski <jarekmorawski@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: Sourav61 <sourav08@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine. Fixes #63366. git-svn-id: https://develop.svn.wordpress.org/branches/6.8@60199 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine. Fixes #63366. Built from https://develop.svn.wordpress.org/branches/6.8@60199 git-svn-id: http://core.svn.wordpress.org/branches/6.8@59535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. git-svn-id: https://develop.svn.wordpress.org/trunk@60205 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. Built from https://develop.svn.wordpress.org/trunk@60205 git-svn-id: http://core.svn.wordpress.org/trunk@59541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Apr 28, 2025
This includes the following changes: - WordPress/gutenberg#69958 - WordPress/gutenberg#70006 - WordPress/gutenberg#70001 - WordPress/gutenberg#69998 - WordPress/gutenberg#70000 This was done in the 6.8 branch in [60199]. Since trunk's packages have not yet been updated for 6.9, this will allow for bug fixes in the 6.8 branch to also be available to people testing trunk. Props wildworks, 0mirka00, sourav08, mamaduka, megane9988, jorbin, dsawyers, iamkingsleyf, soean, sc0ttkclark, presstoke, yogeshbhutkar, joen, joedolson, talldanwp, jarekmorawski, yogeshbhutkar, fabiankaegy, justlevine, desrosj. Fixes #63366. Built from https://develop.svn.wordpress.org/trunk@60205 git-svn-id: https://core.svn.wordpress.org/trunk@59541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…p” view (WordPress#69958) * Revert "Split view with meta boxes even with legacy canvas (WordPress#66706)" This reverts commit 7631986. * Keep meta boxes unsplit from content in device previews Cherry picked from 2a8dc37 on branch wp/6.7 --------- Conflicts: packages/edit-post/src/components/layout/index.js Unlinked contributors: thekendog, jpmuldoon, Traxus, akmyta, tsimshatsui, robmcclel, tatof, kubixz39, cucocreative, ddryo, daniellacatus. Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: sc0ttkclark <sc0ttkclark@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Soean <soean@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: iamkingsleyf <iamkingsleyf@git.wordpress.org> Co-authored-by: witchblade32 <dsawyers@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: megane9988 <megane9988@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7631986 from #66706. The revert applied with no conflicts.
This includes 2a8dc37 to address #66629 (device preview issues).
What?
Closes #69923 and makes the post editor, with regards to meta boxes, work just like it did in 6.7.2
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast