ToC: Fix related block attribute persistence #69734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -169 B (-0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8ecae63. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14111538674
|
|
I don't have too much context here, but I rebased this on top of 1291719 (#69063) locally, and can confirm it fixes the bug I observed and mentioned here #69063 (comment) :) I also tested per the testing instructions above, and this solves it. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test ReportDescriptionHey @Mamaduka, Actual Results✅ Issue resolved with patch. Supplemental ArtifactsBefore FixScreen.Recording.2025-03-28.at.12.17.34.PM.movAfter FixScreen.Recording.2025-03-28.at.12.19.45.PM.mov |
|
Thanks for testing, @gmovr and @Infinite-Null! |
|
Hey @Mamaduka, |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: gmovr <etobiesen@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #67583
PR fixes a bug in the Table of Contents block where the Save button remained disabled even after making changes to the heading block.
How
Execute the ToC block attribute sync via microtask to avoid leaking the non-persistent attribute update marker.
Testing Instructions
Testing Instructions for Keyboard
Same.