Tag Cloud: Remove unnecessary full-width padding #69725
Merged
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Thank you, @dhruvikpatel18!
The reasoning for removal makes sense here ✅
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58886
What?
Remove unnecessary padding for full-width Tag Cloud block
Why?
The current implementation adds unexpected left and right padding when the Tag Cloud block is set to full width. This padding contradicts the expected full-width behavior and is no longer necessary with modern theme alignment techniques like
useRootPaddingAwareAlignments.The original padding was added in #27342, but the use case is no longer valid with current WordPress block editor capabilities.
Testing Instructions
Screenshots or screencast
Before
Tag.cloud.before.mov
After
Tag.cloud.after.mov