Skip to content

Post Template Panel: Render create-new-template-modal over post-template-panel #69713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Mar 26, 2025

What?

Closes #69712

This PR fixes a bug where the Post Template Panel partially overlaps the Create New Template modal.

Why?

The overlap prevents access to essential functionalities on certain devices.

How?

A higher z-index was provided to the create-new-template modal.

Testing Instructions

  1. Set the browser width to 1400px or use the iPad Air (landscape) dimensions from the responsive presets.
  2. Create a new page and open it in editing mode.
  3. In the page sidebar, click the button present beside the label Template.
  4. Confirm that the Create New Template modal is now completely visible.
  5. Also, confirm that the Create button is properly accessible.

Testing Instructions for Keyboard

Same.

Screenshots

Before After
before after

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review March 26, 2025 10:45
Copy link

github-actions bot commented Mar 26, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor labels Mar 26, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up! This approach makes sense to me.

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 27, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 27, 2025
@t-hamano t-hamano merged commit 87b3aa3 into WordPress:trunk Mar 27, 2025
70 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 27, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…ordPress#69713)

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Template Panel partially obscures Create New Template modal on Tablet/iPad screens
3 participants