Skip to content

Workflows: Ignore 'block-serialization-default-parser' for manual backports #69791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Apr 2, 2025

What?

PR adds block-serialization-default-parser to the ignored paths for the "Verify Core Backport Changelog" workflow.

Why?

Changes from this package are automatically synced during package updates. See:

https://github.com/WordPress/wordpress-develop/blob/99186cb02f97f367ad859eeba278cfc962904c71/tools/webpack/packages.js#L126-L133

Testing Instructions

Confirm that the ignore pattern is correct. Testing these changes without merging the workflow is difficult.

@Mamaduka Mamaduka added [Type] Build Tooling Issues or PRs related to build tooling GitHub Actions Pull requests that update GitHub Actions code labels Apr 2, 2025
@Mamaduka Mamaduka self-assigned this Apr 2, 2025
@Mamaduka Mamaduka requested a review from desrosj as a code owner April 2, 2025 07:25
@Mamaduka Mamaduka requested a review from t-hamano April 2, 2025 07:26
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was just wondering if #69785 needed a core backport PR, but am happy to see that a backport is not needed.

Copy link

github-actions bot commented Apr 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member Author

Mamaduka commented Apr 2, 2025

Thanks for the review, @t-hamano!

@Mamaduka Mamaduka merged commit cf99725 into trunk Apr 2, 2025
67 checks passed
@Mamaduka Mamaduka deleted the update/backport-changelog-workflow-block-parser branch April 2, 2025 08:00
@github-actions github-actions bot added this to the Gutenberg 20.7 milestone Apr 2, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…kports (WordPress#69791)

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub Actions Pull requests that update GitHub Actions code [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants