Skip to content

Fix: Incorrect Type of wp_widget_factory in render_block_core_legacy_widget Doc Block #69775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Debarghya-Banerjee
Copy link
Contributor

Copy link

github-actions bot commented Mar 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Debarghya-Banerjee <debarghyabanerjee@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 31, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Debarghya-Banerjee! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets labels Apr 1, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @Debarghya-Banerjee!

Note: normally, a PR that includes PHP changes needs to prepare an additional PR for core, as they won't be synced automatically to core. However, PHP files inside @wordpress/widgets are automatically synced, so we don't need to prepare a PR to backport this PR.

@t-hamano t-hamano added No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core props-bot Adding this label triggers the Props Bot workflow for a PR. labels Apr 2, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Apr 2, 2025
@t-hamano t-hamano merged commit 4776ef1 into WordPress:trunk Apr 2, 2025
73 of 77 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.7 milestone Apr 2, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
Co-authored-by: Debarghya-Banerjee <debarghyabanerjee@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Type of Global wp_widget_factory Mentioned in Doc Block of render_block_core_legacy_widget
2 participants