Fix: Space visualizer showing previous value #69747
Conversation
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
This is great! Thanks for working on it. I’ve experimented with some alternatives and it does seem like leveraging a MutationObserver is the best bet.
I’ve tested this and didn’t find any problems. I think it might not be necessary to observe the class attribute and just the style may suffice but I don’t think it’s likely to be critical for performance and may be helpful in some less common cases.
I’d be okay with this landing as is but I have a few suggestions.
9089c02 to
a3b76b8
Compare
* Fix: Space visualizer showing previous value * Refactor: replace useLayoutEffect with useEffect and remove unnecessary value from deps Co-authored-by: karthikeya-io <karthikeya01@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
What?
Part of #63191
Why?
Fixes the issue that Margin and Padding visualizer shows the previous value. This issue doesn't occur in Safari but occurs in Chromium based browsers.
Related PR #59227
How?
Use
MutationObserverto observe the changes in block.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
space-visualizer-before.mov
space-visualizer-after.mov