PatternsExplorerModal: Fix empty patterns in starter content category #69629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this PR to the project board because the Starter Content category is new to WP 6.8. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 19, 2025
|
@Mamaduka Thanks for the review! |
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 20, 2025
…#69629) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 64a36f2 |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69629) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up #66819
This PR properly displays starter patterns in the Pattern Explorer modal.
Why? How?
I found that this modal is missing the logic to handle the starter content category. I add the same logic as the pattern category preview:
gutenberg/packages/block-editor/src/components/inserter/block-patterns-tab/pattern-category-previews.js
Lines 83 to 88 in 2a21c93
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After