CustomSelectControl: Use dynamic fill color for check icon
#69626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thank you @yogeshbhutkar This change works well for me .
While testing this, I came across CustomSelectControl v2. It had a similar problem in dark mode. and with this change that too will get resolved
|
im3dabasia
approved these changes
Mar 19, 2025
t-hamano
reviewed
Mar 19, 2025
0028f9d to
f9fe673
Compare
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ss#69626) * fix: use dynamic fill color for `check` icon * chore: add changelog * fix: simplify CSS Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69625
The
Checkicon displayed next to the selected option does not adapt properly to the theme.Why?
Since no explicit fill value is applied, the
Checkicon defaults to its standard appearance.How?
A simple
fill: currentColor;CSS rule fixed it.Testing Instructions
npm run storybook:dev)CustomSelectControl.Checkicon is visible across all the themes (especially dark theme).CustomSelectControlV2implementations.Screenshots