Skip to content

Storybook: Update ToolbarItem and ToolbarDropdownMenu exports #69618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rishit30G
Copy link
Contributor

@Rishit30G Rishit30G commented Mar 19, 2025

What?

Closes #69616

Why?

This PR resolves the issue of the ToolbarItem and ToolbarDropdownMenu components not showing their props in the Storybook props table for Toolbar

How?

This PR updates the named exports of ToolbarItem and ToolbarDropdownMenu components

Testing Instructions

  • Run npm run storybook:dev
  • Go to Toolbar component story
  • Notice the ToolbarItem and ToolbarDropdownMenu now show their respective props with documentation

Screenshots or screencast

image image

@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers Developer Experience Ideas about improving block and theme developer experience labels Mar 19, 2025
@Mamaduka
Copy link
Member

@Rishit30G, is this ready for the review?

cc @WordPress/gutenberg-components

@Rishit30G Rishit30G marked this pull request as ready for review March 19, 2025 06:50
@Rishit30G Rishit30G requested a review from ajitbohra as a code owner March 19, 2025 06:50
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Rishit30G
Copy link
Contributor Author

Yes @Mamaduka, this one is now ready for review, thanks for the ping 👍🏻

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rishit30G!

This works well for me, and the export style matches other components.

@Mamaduka Mamaduka merged commit 9e3ff3f into WordPress:trunk Mar 19, 2025
69 of 70 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.6 milestone Mar 19, 2025
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…69618)

Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToolbarItem, ToolbarDropdownMenu: Props are missing from Storybook props table
2 participants